Added phpredis sentinel auth #698
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the PhpredisClientFactory to allow for password authentication when using redis sentinel. The default is to use the password set in the parameters password configuration, but also allows for an override in the dsn.
ostrolucky
force-pushed
the
master
branch
13 times, most recently
from
74526a2
to
460c9dc
Compare
|
I've worked on this, but I realized this approach cannot work as is, because it requires having same password on both: sentinel and redis servers. In case somebody had password on redis servers only and sentinel unprotected, this change will attempt to auth the sentinel now and connection will fail. Needs some rethinking. |
ostrolucky
added
feature
|
Predis also doesn't support this predis/predis#594 And they have a same concern as I have pointed out: username/password cannot be reused for sentinel, there should be different configuration. And at this point I don't really want to introduce it, because if we introduce new option and later predis introduces separate one, it will most likely be a different option and we would then have to support both :/ |
ostrolucky
force-pushed
the
master
branch
9 times, most recently
from
08c1156
to
5a26333
Compare
ostrolucky
force-pushed
the
master
branch
2 times, most recently
from
905836e
to
7f51a8e
Compare
ostrolucky
force-pushed
the
master
branch
2 times, most recently
from
28c7a61
to
04a23d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the PhpredisClientFactory to allow for password authentication when using redis sentinel. The default is to use the password set in the parameters password configuration, but also allows for an override in the dsn.
#697 (comment)