fix leak by releasing ref to observed element #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeAstapov
force-pushed
the
fix-mem-leak
branch
from
510ccc3
to
f1b3f14
Compare
|
Hi @snewcomer! Would you be able to take a look into changes proposed here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add an observed element to
elementsarray every time we call.observe()however we don't remove the observed element fromelementsarray when we call.unobserve().this leads to memory leaks in cases e.g. when we render component and use
{{in-viewport}}modifier and then destroy component - reference to the observed element would be held up