Clean up workflows #119
Clean up workflows #119
Conversation
sondrelg
force-pushed
the
fix-workflows
branch
11 times, most recently
from
1de12e4
to
38ed852
Compare
Since Poetry's lockfile formats aren't backwards compatible, we run into issues in our tests if we keep a v1.3.x version and vice versa for v1.2. This way each test can generate the format it needs.
It's failing for some reason, and I can't figure out how this tests anything novel, so let's remove it.
This might break a couple of workflows (hope not), but it's been 18 months since we changed the workflow to not rely on these, and the readme-examples have always used `v1`, so think the likelihood of things breaking for people is sufficiently low to finally go ahead with this.
sondrelg
force-pushed
the
fix-workflows
branch
from
38ed852
to
0453357
Compare
|
I generally only test for the current version in my projects. The test for previous versions exist on the git at the tagged commit, so there is no need to keep them around imo. |
|
IIRC we explicitly would fetch from the repo no the |
|
This just bit me FWIW. I’m not complaining. It should be easy enough to fix. Rather, is there a preferred way to stay up-to-date? Should I just follow the project? I’m not a super active user and mostly use this with buildbot pr’s. |
|
Sorry @gitonthescene 🙇 We just made poor design decisions for the version < 1.2. Won't happen again. If you change the tag to |
|
Really no worries at all. I changed it to |
Updates versions and purges a few tests. Also notably removes the old scripts needed to run the workflow for tags < 1.2.
It has been 18 months since v1.2 was released and the readme-examples have always used the
@v1tag. The workflow likely didn't have many users before this, so I doubt many if any will be affected by this.@miigotu what do you think. It's not ideal, but it would be really nice to get rid of these. The old-script test is now also failing randomly, which is what made now seem like a good time :)