Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve windows 3.8 issue #98

Merged
merged 3 commits into from Oct 12, 2022
Merged

Resolve windows 3.8 issue #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aac5689
chore: Expand matrix for non-default settings test
sondrelg Oct 11, 2022
8313ac4
fix: Use old install script for Windows targets
sondrelg Oct 11, 2022
805b1a2
chore: Add Python version to job name
sondrelg Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Expand Up @@ -7,6 +7,7 @@ defaults:
shell: bash

jobs:

# Make sure the action works using the default settings
test-install:
name: default ${{ matrix.poetry-version }} ${{ matrix.os }} ${{ matrix.python-version }}
Expand All @@ -33,17 +34,18 @@ jobs:

# Make sure the action sets config options correctly
test-config-options:
name: Set non-standard config options - ${{ matrix.os }}
name: non-standard config - ${{ matrix.os }} ${{ matrix.python-version }}
strategy:
fail-fast: true
matrix:
os: [ ubuntu-latest, macos-latest, windows-latest ]
python-version: [ "3.7", "3.8", "3.9", "3.10", "3.11.0-rc.2" ]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: "3.10"
python-version: "${{ matrix.python-version }}"
- uses: ./
with:
version: 1.2.1
Expand Down
7 changes: 6 additions & 1 deletion main.sh
View file
Open in desktop
Expand Up @@ -8,7 +8,12 @@ YELLOW="\033[33m"
RESET="\033[0m"

INSTALLATION_SCRIPT="$(mktemp)"
curl -sSL https://install.python-poetry.org/ --output "$INSTALLATION_SCRIPT"

if [ "${RUNNER_OS}" == "Windows" ]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dislike this much lol, can we fix this another way to keep using the latest installer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what we were doing prior to v1.3.2, one week ago, so in that sense it's not a huge change; but I agree I would never accept this if we had been on the official installation script from the beginning.

As far as I can tell there isn't another way to do this, until the upstream bug is fixed; but I would consider this a temporary band-aid until that happens. Maybe we could even assist in that. It would just be nice to have this working on the @v1 tag for windows users in the meantime.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Just need to fix it somehow after the release. Can you link the upstream issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python-poetry/install.python-poetry.org#46

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened an issue for powershell support, and one to remove the deprecated installation script. Will merge this now and release v1.3.3 👍

curl -sSL https://raw.githubusercontent.com/python-poetry/poetry/48339106eb0d403a3c66519317488c8185844b32/install-poetry.py --output "$INSTALLATION_SCRIPT"
else
curl -sSL https://install.python-poetry.org/ --output "$INSTALLATION_SCRIPT"
fi

echo -e "\n${YELLOW}Setting Poetry installation path as $INSTALL_PATH${RESET}\n"
echo -e "${YELLOW}Installing Poetry 👷${RESET}\n"
Expand Down