Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: snyk woof ro language support and tests #5166

Merged
merged 2 commits into from
Apr 18, 2024
Merged

feat: snyk woof ro language support and tests #5166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
493abe4
feat: snyk woof ro language support and tests
mgyorke Apr 16, 2024
955443f
chore: use jest table tests instead of forEach
mgyorke Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cli/commands/woof.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { MethodArgs } from '../args';
import getWoof from './woof/getWoof';

export default function woof(...args: MethodArgs) {
export default function woof(...args: MethodArgs): void {
const woof = getWoof(args);
console.log(`
| |
Expand Down
1 change: 1 addition & 0 deletions src/cli/commands/woof/getWoof.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const woofs = {
cs: ' Haf!',
uk: ' Гав!',
de: 'Wuff!',
ro: ' Ham!',
cat: 'Meow?',
};

Expand Down
27 changes: 21 additions & 6 deletions test/jest/acceptance/woof.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,43 @@
import { runSnykCLI } from '../util/runSnykCLI';

describe('woof', () => {
// supported languages
const languages = [
{ langCode: 'en', expectedWoof: 'Woof!' },
{ langCode: 'he', expectedWoof: 'בה! ' },
{ langCode: 'ru', expectedWoof: 'Гав!' },
{ langCode: 'es', expectedWoof: 'Guau!' },
{ langCode: 'cs', expectedWoof: 'Haf!' },
{ langCode: 'uk', expectedWoof: 'Гав!' },
{ langCode: 'de', expectedWoof: 'Wuff!' },
{ langCode: 'ro', expectedWoof: 'Ham!' },
{ langCode: 'cat', expectedWoof: 'Meow?' },
];

// test default
it('Woofs in English by default', async () => {
const { stdout, code, stderr } = await runSnykCLI(`woof`);

expect(stdout).toContain('Woof!');
expect(code).toBe(0);
expect(stderr).toBe('');
});

// test unsuported
it('Woofs in English when passed unsupported language', async () => {
const { stdout, stderr, code } = await runSnykCLI(
`woof --language=blalbla`,
);

expect(stdout).toContain('Woof!');
expect(code).toBe(0);
expect(stderr).toBe('');
});

it('Woofs in Czech when passed "cs"', async () => {
const { stdout, code, stderr } = await runSnykCLI(`woof --language=cs`);

expect(stdout).toContain('Haf!');
// test each supported language code
test.each(languages)('Woofs in %s', async ({ langCode, expectedWoof }) => {
const { stdout, code, stderr } = await runSnykCLI(
`woof --language=${langCode}`,
);
expect(stdout).toContain(expectedWoof);
expect(code).toBe(0);
expect(stderr).toBe('');
});
Expand Down