Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add properties to the lockfile (ref: #98) #112

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

abdulhannanali
Copy link

What this does

This PR mainly adds following four properties to the lockfile dependency tree that were previously ignored

  • resolved
  • integrity
  • checksum
  • resolution

It also updates the expected dependency tree fixtures accordingly and moves yarn.test.ts to the jest. The file was moved to jest since it was timing out with tap and the test comparison was taking forever to run. I pledge to move the whole test code of this repo to Jest and also add snapshotting to make it simpler for everyone to add properties in future.

Explain why this PR exists

This PR exists since we want this functionality for lirantal/lockfile-lint#101 and @orsagie showed willingness for these properties to be added in the repo #98

Notes for the reviewer

Instructions on how to run this locally, background context, what to review, questions…

More information

Screenshots

Visuals that may help the reviewer

@abdulhannanali abdulhannanali requested a review from a team as a code owner May 16, 2021 20:58
@CLAassistant
Copy link

CLAassistant commented May 16, 2021

CLA assistant check
All committers have signed the CLA.

@abdulhannanali abdulhannanali changed the title Resolved integrity addition Fixes #101 May 16, 2021
@abdulhannanali abdulhannanali changed the title Fixes #101 Fixes #98 May 16, 2021
@abdulhannanali abdulhannanali changed the title Fixes #98 Add properties to the lockfile (ref: #98) May 16, 2021
@abdulhannanali
Copy link
Author

@lirantal Could you take a look at this when you get a chance, so we can move lirantal/lockfile-lint#101 forward?

@admons
Copy link
Contributor

admons commented May 18, 2021

Hey @abdulhannanali , thanks for raising this PR!
We currently have some WIP branch and prioritised to do some work on this area in the next sprint (or the one after)
we'll see what's missing and might use this PR

We'll let you know when we'll get to this

@abdulhannanali
Copy link
Author

@admons Thanks for considering. I look forward for this integration. Just curious, is it about the dependency graph? I would love to contribute in that area, if given some directions about approach, if you're accepting contributions there.

Copy link

@milahu milahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

60853a7 lgtm : )

we'll see what's missing and might use this PR

is funny, cos the whole point of lockfiles are urls and checksums

@abdulhannanali
Copy link
Author

abdulhannanali commented Sep 17, 2021

@milahu Thank you very much for approving. I am up for resolving the merge conflicts, if you would like.

@calderonth
Copy link

Hello!
Would be keen to know the status of this PR?
It seemed like it was addressing missing features from the lockfile parsing logic.
@lirantal @admons

@calderonth
Copy link

@JamesPatrickGill , sorry to tag, would be keen on knowing what could be done for this PR to reset/progress again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants