-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add properties to the lockfile (ref: #98) #112
base: main
Are you sure you want to change the base?
Add properties to the lockfile (ref: #98) #112
Conversation
@lirantal Could you take a look at this when you get a chance, so we can move lirantal/lockfile-lint#101 forward? |
Hey @abdulhannanali , thanks for raising this PR! We'll let you know when we'll get to this |
@admons Thanks for considering. I look forward for this integration. Just curious, is it about the dependency graph? I would love to contribute in that area, if given some directions about approach, if you're accepting contributions there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
60853a7 lgtm : )
we'll see what's missing and might use this PR
is funny, cos the whole point of lockfiles are urls and checksums
@milahu Thank you very much for approving. I am up for resolving the merge conflicts, if you would like. |
@JamesPatrickGill , sorry to tag, would be keen on knowing what could be done for this PR to reset/progress again? |
What this does
This PR mainly adds following four properties to the lockfile dependency tree that were previously ignored
resolved
integrity
checksum
resolution
It also updates the expected dependency tree fixtures accordingly and moves
yarn.test.ts
to thejest
. The file was moved to jest since it was timing out with tap and the test comparison was taking forever to run. I pledge to move the whole test code of this repo to Jest and also add snapshotting to make it simpler for everyone to add properties in future.Explain why this PR exists
This PR exists since we want this functionality for lirantal/lockfile-lint#101 and @orsagie showed willingness for these properties to be added in the repo #98
Notes for the reviewer
Instructions on how to run this locally, background context, what to review, questions…
More information
Screenshots
Visuals that may help the reviewer