Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "straight to depgraph" fn for yarnlock v1 #140

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JamesPatrickGill
Copy link
Member

Better description coming in future

Basically a WIP implementation of a procedural approach to getting a dep-graph from a lock-file, it skips the dep-tree entirely. And IMO is much easier to read and reason about as well as easier to add logic to.

Caveats (...so far):

  • Cycles handled differently - instead of nodes such as debug@2.0.0|1 and debug@2.0.0|2 these are now debug@2.0.0 and debug@2.0.0|1. I believe these should behave correctly across the system as labels and other data is identical. Done because it allows us to not worry about cycles upfront and move the logic into the depgraph generation loop.
  • Loads of behaviour not implemented the the buildDepTree does but I think but they should all be simple enough to add to this procedural approach.

@JamesPatrickGill JamesPatrickGill force-pushed the feat/convert-yarn-lock-1-direct-to-graph branch from 6b87005 to 438d829 Compare May 7, 2022 20:59
@JamesPatrickGill JamesPatrickGill force-pushed the feat/convert-yarn-lock-1-direct-to-graph branch from 438d829 to 7d8eeb7 Compare May 7, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant