Feat/build dep graph #81
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
milahu
reviewed
Aug 9, 2023
| @@ -24,6 +25,7 @@ import { | |||
| export { | |||
| buildDepTree, | |||
| buildDepTreeFromFiles, | |||
| buildDepGraphFromFiles, | |||
There was a problem hiding this comment.
stupid question:
what is the difference between buildDepTree and buildDepGraph?
(since npm allows cyclic dependencies, it should always be a graph)
There was a problem hiding this comment.
Wow this is an old pr 🤪 maybe should close it. Yea Snyk started with a tree where cycles were terminated, and has now moved over to a graph where cycles are possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Generate dep-graphs from package-lock.json
More information