Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove then-fs dependency #42

Closed
wants to merge 1 commit into from
Closed

feat: remove then-fs dependency #42

wants to merge 1 commit into from

Conversation

JackuB
Copy link
Contributor

@JackuB JackuB commented Jun 16, 2020

Following removal of then-fs in snyk CLI snyk/cli#1137 I'm trying to remove it from other dependencies as well.

@JackuB
feat: remove then-fs dependency
d1e615c 
Use native fs module
@CLAassistant
Copy link

CLAassistant commented Jun 16, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 89.308% when pulling d1e615c on feat/remove-then-fs into dec6970 on master.

@JackuB JackuB marked this pull request as ready for review June 16, 2020 15:50
@JackuB JackuB requested a review from a team June 16, 2020 15:50
@ghost ghost requested review from gablaxian and removed request for a team June 16, 2020 15:50
@JackuB JackuB requested a review from a team June 25, 2020 14:43
@ghost ghost requested review from anthogez and MegaBean June 25, 2020 14:43
@JackuB JackuB requested a review from a team June 25, 2020 14:43
@gablaxian
Copy link

Swapped out then-fs for promise-fs instead:
#43

@gablaxian gablaxian closed this Jul 20, 2020
@gablaxian gablaxian deleted the feat/remove-then-fs branch July 20, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gablaxian gablaxian Awaiting requested review from gablaxian

@anthogez anthogez Awaiting requested review from anthogez

@MegaBean MegaBean Awaiting requested review from MegaBean

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JackuB @CLAassistant @coveralls @gablaxian