Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: then-fs -> promise-fs #11

Merged
merged 1 commit into from Jul 19, 2020
Merged

feat: then-fs -> promise-fs #11

merged 1 commit into from Jul 19, 2020

Conversation

FauxFaux
Copy link
Contributor

then-fs seems to be causing a memory leak in jest in other tools. It's abandoned, and graceful-fs is a drop-in replacement.

Found by jestjs/jest#8331

@coveralls
Copy link

coveralls commented Jul 18, 2020 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling eab91b3 on feat/then-fs into c89e9bc on master.

@FauxFaux FauxFaux marked this pull request as ready for review July 18, 2020 10:37
@FauxFaux FauxFaux requested a review from a team as a code owner July 18, 2020 10:37
@ghost ghost requested review from anthogez and aviadhahami July 18, 2020 10:37
@FauxFaux FauxFaux changed the title feat: then-fs -> graceful-fs feat: then-fs -> promisify-fs Jul 18, 2020
@FauxFaux
feat: then-fs -> promise-fs
eab91b3 
then-fs seems to be causing a memory leak in jest in other tools.

Found by jestjs/jest#8331
@FauxFaux FauxFaux changed the title feat: then-fs -> promisify-fs feat: then-fs -> promise-fs Jul 18, 2020
@aviadhahami aviadhahami merged commit 2dcee4c into master Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviadhahami aviadhahami aviadhahami approved these changes

@anthogez anthogez Awaiting requested review from anthogez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FauxFaux @coveralls @aviadhahami