Merge pull request #23 from snyk/chore/update-cci-config

chore/update cci config
snyk · Mar 27, 2020 · a84603e · a84603e
2 parents 39bdde0 + 1c61e23
commit a84603e
Show file tree

Hide file tree

Showing 7 changed files with 830 additions and 115 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -3,17 +3,9 @@ version: 2.1
 defaults: &defaults
   resource_class: small
   docker:
-    - image: gcr.io/snyk-main/nsolid-ubuntu:erbium
-      auth:
-        username: _json_key
-        password: $GCLOUD_GCR_BUILDER
+    - image: node:12
   working_directory: ~/rpm-parser
 
-private_cicd_repo_auth: &private_cicd_repo_auth
-  auth:
-    username: _json_key
-    password: $GCLOUD_GCR_BUILDER
-
 commands:
   install_deps:
     description: Install dependencies
@@ -51,11 +43,18 @@ jobs:
     steps:
       - install_deps
 
+  lint:
+    <<: *defaults
+    steps:
+      - checkout
+      - attach_workspace:
+          at: ~/rpm-parser
+      - run:
+          name: Lint
+          command: npm run lint
+
   test:
     <<: *defaults
-    docker:
-      - image: gcr.io/snyk-main/nsolid-ubuntu:erbium
-        <<: *private_cicd_repo_auth
     steps:
       - checkout
       - attach_workspace:
@@ -70,7 +69,7 @@ jobs:
       - checkout
       - run:
           name: Release on GitHub
-          command: npx semantic-release
+          command: exit 1 # npx semantic-release
 
 workflows:
   version: 2
@@ -84,6 +83,16 @@ workflows:
             branches:
               ignore:
                 - master
+
+      - lint:
+          name: Lint
+          context: nodejs-install
+          requires:
+            - Install with devDependencies
+          filters:
+            branches:
+              ignore:
+                - master
       - test:
           name: Test
           context: nodejs-install
@@ -98,6 +107,7 @@ workflows:
           context: nodejs-install
           requires:
             - Test
+            - Lint
           filters:
             branches:
               ignore:
@@ -112,6 +122,15 @@ workflows:
             branches:
               only:
                 - master
+      - lint:
+          name: Lint
+          context: nodejs-install
+          requires:
+            - Install with devDependencies
+          filters:
+            branches:
+              only:
+                - master
       - test:
           name: Test
           context: nodejs-install
@@ -126,6 +145,7 @@ workflows:
           context: nodejs-install
           requires:
             - Test
+            - Lint
           filters:
             branches:
               only:
@@ -136,6 +156,7 @@ workflows:
           requires:
             - Install with devDependencies
             - Test
+            - Lint
             - Install PROD deps
           filters:
             branches:

diff --git a/.eslintrc.json b/.eslintrc.json
@@ -0,0 +1,22 @@
+{
+  "parser": "@typescript-eslint/parser",
+  "parserOptions": {
+    "project": "./tsconfig.json",
+    "extraFileExtensions": [".ts"]
+  },
+  "plugins": ["@typescript-eslint"],
+  "extends": [
+    "plugin:@typescript-eslint/recommended",
+    "prettier",
+    "prettier/@typescript-eslint"
+  ],
+  "rules": {
+    "@typescript-eslint/semi": "error",
+    "@typescript-eslint/no-use-before-define": "off",
+    "@typescript-eslint/interface-name-prefix": "off",
+    "@typescript-eslint/await-thenable": "error",
+    "@typescript-eslint/ban-ts-ignore": "error",
+    "@typescript-eslint/no-unnecessary-type-assertion": "error",
+    "@typescript-eslint/unbound-method": "error"
+  }
+}
diff --git a/lib/berkeleydb/index.ts b/lib/berkeleydb/index.ts
@@ -119,7 +119,7 @@ export function validateBerkeleyDbMetadata(data: Buffer): void | never {
 /**
  * Exported for testing
  */
-export function validatePageSize(pageSize: number) {
+export function validatePageSize(pageSize: number): void | never {
   if (!validPageSizes.includes(pageSize)) {
     throw new Error(`Invalid page size: ${pageSize}`);
   }