Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add snyk test and snyk code test to pipeline #71

Merged
merged 1 commit into from
Jul 16, 2023
Merged

chore: add snyk test and snyk code test to pipeline #71

merged 1 commit into from
Jul 16, 2023

Conversation

SteveShani
Copy link
Contributor

Add snyk test and snyk code test

@SteveShani SteveShani requested a review from a team as a code owner July 13, 2023 11:15
@SteveShani SteveShani self-assigned this Jul 13, 2023
@SteveShani SteveShani force-pushed the chore/add-snyk-tests-LUM-450 branch 5 times, most recently from 4f94473 to 26b346c Compare July 13, 2023 11:36
@SteveShani SteveShani requested a review from pecodez July 13, 2023 11:53
pecodez
pecodez approved these changes Jul 13, 2023
View reviewed changes
Copy link

@pecodez pecodez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking: still not sure about monitor-on-build. I think we would ideally want this set to true but would also need --project-name being set to stop new project groups being created for each test.

@SteveShani
Copy link
Contributor Author

non-blocking: still not sure about monitor-on-build. I think we would ideally want this set to true but would also need --project-name being set to stop new project groups being created for each test.

I just think it's odd to both have them imported from SCM and always monitor them from the build.

@SteveShani SteveShani force-pushed the chore/add-snyk-tests-LUM-450 branch from 26b346c to a7721fc Compare July 16, 2023 08:16
@SteveShani SteveShani merged commit 93f3de7 into main Jul 16, 2023
10 of 11 checks passed
@SteveShani SteveShani deleted the chore/add-snyk-tests-LUM-450 branch July 16, 2023 14:26
@snyksec
Copy link

snyksec commented Apr 10, 2024

🎉 This PR is included in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pecodez pecodez pecodez approved these changes

@rmutuleanu rmutuleanu Awaiting requested review from rmutuleanu rmutuleanu was automatically assigned from snyk/lumos

Assignees

@SteveShani SteveShani

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SteveShani @snyksec @pecodez