feat: add support for linux arm64 #178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snyk offers pre-built binary for Linux Arm64. One of the usecases for this is running Linux containers on M1/M2 Apple laptops, specifically with 'linux/arm64/v8' arhitecture. This change allows the Snyk Maven plugin to detect the appropriate architecture and download the correct binary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Snyk offers a pre-built binary for Linux Arm64. One of the use-cases for this is running Linux containers on M1/M2 Apple laptops, specifically with 'linux/arm64/v8' architecture. This change allows the Snyk Maven plugin to detect the appropriate architecture and download the correct binary.
Without this change, the error received is
#17 13.87 [ERROR] qemu-x86_64: Could not open '/lib64/ld-linux-x86-64.so.2': No such file or directory, whileuname -mshowsaarch64.I am not fully sure about the state of GitHub Actions tests, they seem to be broken for the past two months. The
surefiretests are passing, and the plugin has been tested to work correctly in a local test context.Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
What are the relevant tickets?
Screenshots
Additional questions