Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New optional config item, fail build based on count as alternative to severity. #58

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

arnemejlholm
Copy link

@arnemejlholm arnemejlholm commented Dec 18, 2019

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Add small optional to fail the build based on vulnerability count instead of severity.

Where should the reviewer start?

PR should be straightforward. I'm unsure about what to do with the version in the pom.xml, but bumped it just in case.

How should this be manually tested?

Configure plugin like this and run against vulnerable project:

            <configuration>
                <failOnSeverity>false</failOnSeverity>
                <failOnCount>5</failOnCount>
            </configuration>

Any background context you want to provide?

Most of our projects does not have the option to fail on a just single severity (low, medium, higher), as the framework we use usually has 2-3 known vulnerabilities even though it has a weekly release cycle. In essence this means that we won't use the snyk maven plugin for testing. For us right now, it makes more sense to be able to fail the build if we have a larger set vulnerabilities e.g. 5 or higher.

What are the relevant tickets?

None

Screenshots

None

Additional questions

None

@arnemejlholm
Copy link
Author

Notice that the tests fail even without my changes.

@CLAassistant
Copy link

CLAassistant commented Dec 14, 2020

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants