Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial GitHub Action workflow for testing code on multiple JDK versions #88

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

geertjanw
Copy link

@geertjanw geertjanw commented Oct 27, 2020

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Initial GitHub Action workflow for testing code on multiple JDK versions.

Where should the reviewer start?

By using the action on GitHub to see that testing succeeds.

How should this be manually tested?

On-line on GitHub.

Any background context you want to provide?

This is useful for on-line automated testing on a variety of JDK versions.

What are the relevant tickets?

Screenshots

Additional questions

@geertjanw geertjanw requested a review from a team as a code owner October 27, 2020 19:39
with:
java-version: ${{ matrix.java }}
- name: Test with Maven
run: mvn test -B --file pom.xml
Copy link
Contributor

@recena recena Oct 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the documentation is recommended to use mvn -B --file pom.xml test I suggest you mvn -B -f pom.xml verify

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, below.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants