Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to allow project version to be appended to the project name #92

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

aoterolorenzo
Copy link
Contributor

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

Closes #91

What does this PR do?

Sets both configuration and CLI option to allow project version to be appended to the project name.

Where should the reviewer start?

Simple changes in SnykMonitor and SnykTest to add the functionality

How should this be manually tested?

Executing the plugin with the configuration parameter on the project's pom or
using the CLI option -Dsnyk.longFormProjectName

Any background context you want to provide?

N/A

What are the relevant tickets?

N/A

Screenshots

N/A

Additional questions

N/A

@aoterolorenzo aoterolorenzo requested a review from a team as a code owner November 24, 2020 09:59
@pavel-snyk
Copy link
Contributor

👋 @aoterolorenzo, we are working on v2 version of the plugin to get rid of some issues with the current plugin version (e.g. deprecated dependency resolution mechanism #23). The v2 version will be based on our CLI and this functionality (overriding project name) is already exist.
That's why I would not add this option to existing version, so configuration options will not be mixed later.
p.s.: I like that you help us to improve the plugin, how about creating an issue next time, so we can discuss functionality first?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants