Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clearTimeout should be called from the same scope as setTimeout #1568

Merged
merged 1 commit into from
Jun 22, 2023
Merged

clearTimeout should be called from the same scope as setTimeout #1568

merged 1 commit into from
Jun 22, 2023

Commits on Dec 28, 2022

  1. clearTimeout should be called from the same scope as setTimeout 

    Details of change:
 - engine.io-client sets clearTimeoutFn and setTimeoutFn
   function depending on settings passed to manager
 - socker.io-client is using manager.setTimeoutFn to
   start connection monitoring timer, but is using regular
   clearTimeout function to stop it when connection is established
 - In some setups it is causing timer fail to stop and it will break
   connection every _timeout_ milliseconds (which is 20000 by default)
    @mast
    mast committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    80d79c8 View commit details
    Browse the repository at this point in the history