fix adapter broadcast bug

socketio · Apr 25, 2024 · a0f2243 · a0f2243
1 parent 14d4997
commit a0f2243
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/parent-namespace.ts b/lib/parent-namespace.ts
@@ -48,7 +48,7 @@ export class ParentNamespace<
    * @private
    */
   _initAdapter(): void {
-    this.adapter = new ParentBroadcastAdapter(this, this.children);
+    this.adapter = new ParentBroadcastAdapter(this);
   }
 
   public emit<Ev extends EventNamesWithoutAck<EmitEvents>>(
@@ -113,12 +113,12 @@ export class ParentNamespace<
  * @private file
  */
 class ParentBroadcastAdapter extends Adapter {
-  constructor(parentNsp: any, private readonly children: Set<Namespace>) {
+  constructor(private readonly parentNsp: any) {
     super(parentNsp);
   }
 
   broadcast(packet: any, opts: BroadcastOptions) {
-    this.children.forEach((nsp) => {
+    this.parentNsp.children.forEach((nsp) => {
       nsp.adapter.broadcast(packet, opts);
     });
   }

diff --git a/test/namespaces.ts b/test/namespaces.ts
@@ -505,6 +505,7 @@ describe("namespaces", () => {
         .on("connect", (socket) => {
           expect(socket.nsp.name).to.be("/dynamic-101");
           dynamicNsp.emit("hello", 1, "2", { 3: "4" });
+          dynamicNsp.to(socket.id).emit("there", 1, "2", { 3: "4" });
           partialDone();
         })
         .use((socket, next) => {