correctly await async close on adapters

socketio · Mar 11, 2024 · fedc36a · fedc36a
1 parent bf64870
commit fedc36a
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/lib/index.ts b/lib/index.ts
@@ -741,14 +741,14 @@ export class Server<
    *
    * @param [fn] optional, called as `fn([err])` on error OR all conns closed
    */
-  public close(fn?: (err?: Error) => void): void {
-    this._nsps.forEach((nsp) => {
+  public async close(fn?: (err?: Error) => void): Promise<void> {
+    await Promise.allSettled([...this._nsps.values()].map(async (nsp) => {
       nsp.sockets.forEach((socket) => {
         socket._onclose("server shutting down");
       });
 
-      nsp.adapter.close();
-    });
+      await nsp.adapter.close();
+    }));
 
     this.engine.close();