Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Custom server instance not attached #4127

Merged
merged 2 commits into from Oct 16, 2021

Conversation

HexaField
Copy link
Contributor

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behavior

custom server instances not running attach function in constructor. this breaks feathers/socketio package which relies on socket.io.

New behavior

custom server instance now runs attach function in constructor

Other information (e.g. related issues)

fixes #4124

@darrachequesne darrachequesne merged commit 0ef2a4d into socketio:master Oct 16, 2021
@HexaField HexaField deleted the fix/not-attaching-server branch October 16, 2021 22:25
dzad pushed a commit to dzad/socket.io that referenced this pull request May 29, 2023
The check excluded an HTTPS server from being properly attached.

Related: socketio#4124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Socket IO 4.3 Breaks HTTPS Support
2 participants