Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Custom server instance not attached #4127

Merged
merged 2 commits into from Oct 16, 2021
Merged

Fix: Custom server instance not attached #4127

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2767eea
fix server not being attached when not a direct instance of https.Ser…
HexaField Oct 16, 2021
991e062
fix test
HexaField Oct 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/index.ts
View file
Open in desktop
Expand Up @@ -156,9 +156,7 @@ export class Server<
this.adapter(opts.adapter || Adapter);
this.sockets = this.of("/");
this.opts = opts;
if (srv instanceof http.Server || typeof srv === "number") {
this.attach(srv);
}
if (srv || typeof srv == "number") this.attach(srv as http.Server | number);
}

/**
Expand Down