Add a watchdog for the heartbeat #601
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
requested changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your client device loose the network connection to the device running the websocket server this will not be detected by the socket client.
This watchdog will be reseted by the heartbeat message (appears every 25 seconds) if the watchdog will not be resetted in a 30 second window the connection can be marked as lost => 1006
Found with OctoPrint, if you connect to the OctoPrint instance with a laptop and this goes to sleep mode for some time (network will be disabled)
After you wake the device again you still see the UI but the websocket connection is not connected anymore.
You can reproduce this by disabling your network on the laptop, wait some time and connect again.