Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

复写Log4jLogger,适配多模块下static final修饰的Logger情况使用 #478

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

suntaiming
Copy link

每次调用日志打印 根据当前线程上下文类加载器动态获取Logger

Copy link

sofastack-cla bot commented Jan 22, 2024

Hi @suntaiming, welcome to SOFAStack community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@sofastack-cla sofastack-cla bot added cla:yes and removed cla:no labels Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 168 lines in your changes are missing coverage. Please review.

Comparison is base (1ec069f) 81.00% compared to head (463e781) 71.17%.
Report is 34 commits behind head on master.

❗ Current head 463e781 differs from pull request most recent head c43ff00. Consider uploading reports for the commit c43ff00 to get more accurate results

Files Patch % Lines
...ain/java/org/apache/logging/slf4j/Log4jLogger.java 0.00% 168 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #478      +/-   ##
============================================
- Coverage     81.00%   71.17%   -9.84%     
  Complexity       64       64              
============================================
  Files            46       47       +1     
  Lines          1216     1384     +168     
  Branches        113      120       +7     
============================================
  Hits            985      985              
- Misses          170      338     +168     
  Partials         61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lvjing2
Copy link
Collaborator

lvjing2 commented Jan 23, 2024

麻烦再补充两点内容

  1. 在 log4j2 的 samples 里再补充个case
  2. log4j2 的适配原理 补充下适配的原理

@sofastack-cla sofastack-cla bot added size/XL and removed size/L labels Feb 8, 2024
@suntaiming
Copy link
Author

麻烦再补充两点内容

  1. 在 log4j2 的 samples 里再补充个case
  2. log4j2 的适配原理 补充下适配的原理

已补充

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants