Fix onBegin and onTouchesDown events ordering on Android
#2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-bert
approved these changes
Jul 21, 2023
j-piasecki
force-pushed
the
@jpiasecki/fix-event-order-android-2
branch
from
89aea03
to
d58e6cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the ordering of
onBeginandonTouchesDownevents on Android.onBeginwas invoked first, as some gestures required additional setup when they started tracking the first pointer, which is happening after the touch events are dispatched. The workaround for that was to sendonTouchesDownlater but it resulted in inconsistent behavior between platforms.The gesture initialization is now abstracted to the parent class and may be invoked by touch events. The one caveat is that it requires an instance of
MotionEventso one needs to be remembered when dispatching the touch event.Fixes part of #2263.
Test plan
Tested on the example app and on the code from the issue.