-
-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Next
example app
#2855
Draft
m-bert
wants to merge
23
commits into
@mbert/next-compatibility-v2
Choose a base branch
from
@mbert/add-next-example
base: @mbert/next-compatibility-v2
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add Next
example app
#2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-bert
changed the base branch from
@mbert/add-react-compact
to
@mbert/next-compatibility-v2
April 22, 2024 07:55
## Description This PR is a successor of #2867 - it solves problems that were present in mentioned PR, namely: 1. changes type of offset properties of `Pan` into `number | [number, number]`, so that it is impossible to assign to them something else than number or array with 2 numbers 2. adds type cast in `withPrevAndCurrent` function (used in `jest`) ## Test plan Try to assign something else than number or array of two numbers to any of changed properties - error should appear.
## Summary This pr includes changes to dynamically build OG Images for every single subpage in docs. ## How does it work? The algorithm runs after docusaurus build. It reads titles from markdown files in docs dictionary, generates images and place .png files in the build dictionary. Docusaurus has been configured to automatically link to generated OG Images. ## How to test this feature? Command to change current working dictionary: > cd docs Command to download libraries: > yarn install Command to build project and generete OG Images: > yarn build Command to see the result: > yarn serve
## Description This PR upgrades React Native version in our FabricExample app to 0.74 ## Test plan Build FabricExample app on android and iOS (with fabric enabled and not)
## Description This PR resolves the recognition issue of the Reanimated Event handler for the previous Gesture Handler API. This adjustment was necessary due to a modification in the internal property name that was utilized to identify the Reanimated event handler (as seen here: software-mansion/react-native-reanimated#5743). ## Test plan Run this example - https://github.com/software-mansion/react-native-reanimated/blob/main/app/src/examples/DragAndSnapExample.tsx
## Description I thought that adding TypeDocs might be a good idea and it could enhance developer experience (I've come up with this idea when I discovered that we have `withRef` modifier). This PR adds TypeDocs to new API (but we can also think of filling missing docs in old API) ## Test plan Hover functions/components and read docs.
## Description Sets the package manager used in the example apps and in the root of the repository to `yarn@1.22.22`. ## Test plan Install dependencies & build apps
## Description Recently I've discovered that using `.minVelocity()` modifier doesn't affect `Pan` activation on web. After further investigation I've found out that list with custom activation criteria had `minVelocityX` and `minVelocityY`, but `minVelocity` was missing. This PR adds mentioned criterion. ## Test plan Tested on example app (just add `.minVelocity()` in any example with `Pan`
## Description Bump version to 2.16.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
Next.js
example to our repository.Test plan
Well... run example app I guess?
cd next-example
yarn dev
localhost:3000