Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GestureDetector #2901

Merged
merged 26 commits into from
May 16, 2024
Merged

Refactor GestureDetector #2901

merged 26 commits into from
May 16, 2024

Conversation

j-piasecki
Copy link
Member

Description

This PR refactors GestureDetector file:

  • splits it into smaller files
  • renames some variables
  • removes redundant logic
  • extracts common logic to utils

Test plan

Test on the Example app

m-bert
m-bert reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@m-bert m-bert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

src/handlers/gestures/GestureDetector/attachHandlers.ts Show resolved Hide resolved
src/handlers/gestures/GestureDetector/useAnimatedGesture.ts Outdated Show resolved Hide resolved
src/handlers/gestures/GestureDetector/utils.ts Outdated Show resolved Hide resolved
src/handlers/gestures/GestureDetector/utils.ts Outdated Show resolved Hide resolved
src/handlers/gestures/GestureDetector/index.tsx Outdated Show resolved Hide resolved
src/handlers/gestures/GestureDetector/index.tsx Outdated Show resolved Hide resolved
@j-piasecki j-piasecki marked this pull request as ready for review May 14, 2024 10:12
m-bert
m-bert approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@m-bert m-bert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy that this file got refactored 😄

src/handlers/gestures/GestureDetector/useViewRefHandler.ts Outdated Show resolved Hide resolved
@j-piasecki j-piasecki merged commit cbaf6b0 into main May 16, 2024
1 check passed
@j-piasecki j-piasecki deleted the @jpiasecki/refactor-detector branch May 16, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-bert m-bert m-bert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@j-piasecki @m-bert