Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace current theme components with @swmansion/t-rex-ui #2906

Merged
merged 21 commits into from
May 22, 2024
Merged

Replace current theme components with @swmansion/t-rex-ui #2906

merged 21 commits into from
May 22, 2024

Conversation

patrycjakalinska
Copy link
Contributor

@patrycjakalinska patrycjakalinska commented May 13, 2024 •
edited

Description

Because of a ramping up maintainance cost across our suite of tools - Reanimated, Gesture Handler & React Native IDE we've decided to create a UI library for our reusable docusaurus components.

This PR replaces old theme components such as Admonition, Sidebar and Table of Contents with new, reusable ones from @swmansion/t-rex-ui.

Full list of replaced components:

  • Admonition
  • PaginatorNavLink
  • DocSidebar
  • DocSidebarItem
  • DocSidebarItems
  • DocCard
  • DocItemTOCMobile
  • DocItemMetadata
  • TOCCollapsible
  • TOCItems
  • TOCItemTree
  • Footer
  • Navbar

SearchPage was also replaced, but this PR is held by incoming @swmansion/t-rex-ui patch with SearchPage export.

Test plan

cd docs/
yarn

# to test development build
yarn start

# to test production build
yarn build
yarn serve

@patrycjakalinska patrycjakalinska changed the title Replace current theme components Replace current theme components with @swmansion/t-rex-ui May 13, 2024
@patrycjakalinska patrycjakalinska requested review from kacperkapusciak and piaskowyk and removed request for piaskowyk and kacperkapusciak May 13, 2024 12:31
@patrycjakalinska patrycjakalinska force-pushed the @patrycjakalinska/use-components-from-t-rex-ui branch from e77c3ca to ea8025e Compare May 14, 2024 07:32
@patrycjakalinska patrycjakalinska force-pushed the @patrycjakalinska/use-components-from-t-rex-ui branch from 0843529 to 3b5e098 Compare May 14, 2024 13:36
m-bert
m-bert reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@m-bert m-bert left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one thing that I've noticed is that the sidebar is no longer scrollable, which is a bit frustrating 😅

m-bert
m-bert requested changes May 19, 2024
View reviewed changes
Copy link
Contributor

@m-bert m-bert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, please look into scrolling problem that I've mentioned earlier and we are good to go

Before

Nagranie.z.ekranu.2024-05-19.o.17.40.24.mov

After

Nagranie.z.ekranu.2024-05-19.o.17.41.45.mov

docs/src/css/overrides.css Outdated Show resolved Hide resolved
@patrycjakalinska patrycjakalinska force-pushed the @patrycjakalinska/use-components-from-t-rex-ui branch from 57d57c3 to b68b7b1 Compare May 22, 2024 06:04
@patrycjakalinska patrycjakalinska removed the request for review from piaskowyk May 22, 2024 06:04
@patrycjakalinska patrycjakalinska force-pushed the @patrycjakalinska/use-components-from-t-rex-ui branch from 77fd7a7 to 010a16a Compare May 22, 2024 13:29
m-bert
m-bert approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@m-bert m-bert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The time has come :shipit:

docs/src/css/overrides.css Outdated Show resolved Hide resolved
@patrycjakalinska patrycjakalinska merged commit 1fdd82c into main May 22, 2024
1 check passed
@patrycjakalinska patrycjakalinska deleted the @patrycjakalinska/use-components-from-t-rex-ui branch May 22, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-bert m-bert m-bert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@patrycjakalinska @m-bert