Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test predefined entering animation #5995

Merged
merged 16 commits into from
May 27, 2024
Merged

Test predefined entering animation #5995

merged 16 commits into from
May 27, 2024

Conversation

Latropos
Copy link
Contributor

@Latropos Latropos commented May 9, 2024

Summary

The tests require about 1minute 40s to run.

The new tests:

  • verify that all the exported predefined entering animations have stable behaviour
  • verify that they work with our most important modifiers: springify & duration

Also I improve the way I deep copy updates

Test plan

image

@Latropos Latropos changed the title Test entering animation Test predefined entering animation May 9, 2024
@Latropos Latropos requested review from tjzel and szydlovsky and removed request for tjzel May 13, 2024 13:12
@Latropos Latropos marked this pull request as ready for review May 13, 2024 13:15
Copy link
Contributor

@szydlovsky szydlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I've ran the tests from the branch myself and 125 tests got skipped - is that supposed to be that way?
image

@Latropos
Copy link
Contributor Author

@szydlovsky

Looks great, I've ran the tests from the branch myself and 125 tests got skipped - is that supposed to be that way?

I've forgot to delete only decorator, now all the tests run

@szydlovsky szydlovsky self-requested a review May 14, 2024 15:09
Copy link
Contributor

@szydlovsky szydlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the tests now run, but some of them fail and we even get a runtime crash with one of them:
image
Do we want to address it now or in a different PR?

@Latropos
Copy link
Contributor Author

Latropos commented May 15, 2024

@szydlovsky This is an expected error, and we want to check that it is thrown. Unfortunately you can't hide render error dialogs in __DEV__ mode, you can only dismis all the yellow warnings.

I suppose that the screenshot above comes from this test:

describe('Invalid easing', async () => {
test.failing(
'Easing imported from react-native throws an error',
'Error: [Reanimated] The easing function is not a worklet. Please make sure you import `Easing` from react-native-reanimated.',
async () => {
await render(
<ErrorBoundary>
<ActiveAnimatedComponent easing={EasingRN.linear} />
</ErrorBoundary>,
);
await wait(1200);
},
);

@szydlovsky
Copy link
Contributor

@Latropos Alright, if all this is expected I don't see any more issues :shipit:

@szydlovsky szydlovsky self-requested a review May 15, 2024 13:01
@Latropos Latropos requested a review from piaskowyk May 22, 2024 11:18
@Latropos Latropos added this pull request to the merge queue May 27, 2024
Merged via the queue into main with commit 86b163d May 27, 2024
6 checks passed
@Latropos Latropos deleted the acynk/entering branch May 27, 2024 11:35
renovate bot added a commit to GSTJ/react-native-magic-modal that referenced this pull request Jun 3, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[react-native-reanimated](https://togithub.com/software-mansion/react-native-reanimated)
| [`~3.11.0` ->
`~3.12.0`](https://renovatebot.com/diffs/npm/react-native-reanimated/3.11.0/3.12.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-reanimated/3.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-reanimated/3.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-reanimated/3.11.0/3.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-reanimated/3.11.0/3.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>software-mansion/react-native-reanimated
(react-native-reanimated)</summary>

###
[`v3.12.0`](https://togithub.com/software-mansion/react-native-reanimated/releases/tag/3.12.0)

[Compare
Source](https://togithub.com/software-mansion/react-native-reanimated/compare/3.11.0...3.12.0)

#### What's Changed

- Give more meaningful warning when modifying a Shareable by
[@&#8203;tjzel](https://togithub.com/tjzel) in
[software-mansion/react-native-reanimated#5548
- Make animated components use different tags for events by
[@&#8203;szydlovsky](https://togithub.com/szydlovsky) in
[software-mansion/react-native-reanimated#5960
- Add `warning` and `failing` test decorators by
[@&#8203;Latropos](https://togithub.com/Latropos) in
[software-mansion/react-native-reanimated#5929
- Update useAnimatedKeyboard docs by
[@&#8203;maciekstosio](https://togithub.com/maciekstosio) in
[software-mansion/react-native-reanimated#5866
- Change the docs to mention, that `.springify()` works with
`.duration()` by [@&#8203;Latropos](https://togithub.com/Latropos) in
[software-mansion/react-native-reanimated#5990
- \[Android]\[Keyboard] More consistent inequality check to compute
keyboard state by [@&#8203;antFrancon](https://togithub.com/antFrancon)
in
[software-mansion/react-native-reanimated#5874
- fix typo on object key for `targetValues` in custom-animations.mdx by
[@&#8203;JDMathew](https://togithub.com/JDMathew) in
[software-mansion/react-native-reanimated#5994
- Remove outdated code for unsupported React Native versions by
[@&#8203;tomekzaw](https://togithub.com/tomekzaw) in
[software-mansion/react-native-reanimated#5979
- Remove REAInitializer by
[@&#8203;tomekzaw](https://togithub.com/tomekzaw) in
[software-mansion/react-native-reanimated#5681
- Prevent crash on non-existent view updates in Android by
[@&#8203;thomas-rx](https://togithub.com/thomas-rx) in
[software-mansion/react-native-reanimated#5767
- Fix location after shared element transition by
[@&#8203;piaskowyk](https://togithub.com/piaskowyk) in
[software-mansion/react-native-reanimated#6010
- Make `useScrollviewOffset` ref nullable and simplify its code by
[@&#8203;szydlovsky](https://togithub.com/szydlovsky) in
[software-mansion/react-native-reanimated#6009
- fix: use proper classes for bridgeless by
[@&#8203;WoLewicki](https://togithub.com/WoLewicki) in
[software-mansion/react-native-reanimated#5997
- docs: add
[@&#8203;swmansion/t-rex-ui](https://togithub.com/swmansion/t-rex-ui) by
[@&#8203;patrycjakalinska](https://togithub.com/patrycjakalinska) in
[software-mansion/react-native-reanimated#6015
- Remove `CellRendererComponent` from Animated.FlatList props by
[@&#8203;Latropos](https://togithub.com/Latropos) in
[software-mansion/react-native-reanimated#5951
- Add `useComposedEventHandler` hook by
[@&#8203;szydlovsky](https://togithub.com/szydlovsky) in
[software-mansion/react-native-reanimated#5890
- Align handling colors with RN by
[@&#8203;maciekstosio](https://togithub.com/maciekstosio) in
[software-mansion/react-native-reanimated#5825
- Add more tests - useSharedValue, useAnimatedStyle , useDerivedValue by
[@&#8203;Latropos](https://togithub.com/Latropos) in
[software-mansion/react-native-reanimated#5981
- Make animation RollInLeft work with modifers by
[@&#8203;Latropos](https://togithub.com/Latropos) in
[software-mansion/react-native-reanimated#6039
- Test predefined entering animation by
[@&#8203;Latropos](https://togithub.com/Latropos) in
[software-mansion/react-native-reanimated#5995
- Tests: cancelAnimation, useFrameCallback, measure, withDecay by
[@&#8203;Latropos](https://togithub.com/Latropos) in
[software-mansion/react-native-reanimated#6016
- docs: fix useAnimatedKeyboard page crash by
[@&#8203;patrycjakalinska](https://togithub.com/patrycjakalinska) in
[software-mansion/react-native-reanimated#6056
- \[Web LA] Remove `existingTransform` by
[@&#8203;m-bert](https://togithub.com/m-bert) in
[software-mansion/react-native-reanimated#6060

#### New Contributors

[@&#8203;antFrancon](https://togithub.com/antFrancon),
[@&#8203;JDMathew](https://togithub.com/JDMathew),
[@&#8203;thomas-rx](https://togithub.com/thomas-rx),
[@&#8203;exploIF](https://togithub.com/exploIF)

#### 🙌 Thank you for your contributions!

**Full Changelog**:
software-mansion/react-native-reanimated@3.11.0...3.12.0

Package build:
https://github.com/software-mansion/react-native-reanimated/actions/runs/9287839734

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/GSTJ/react-native-magic-modal).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants