-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monorepo [2/?] - use hoisted dependencies for Reanimated, app common code and paper example #5999
Open
tjzel
wants to merge
13
commits into
@tjzel/monorepo-husky-and-precommit
Choose a base branch
from
@tjzel/monorepo-make-reanimated-a-workspace
base: @tjzel/monorepo-husky-and-precommit
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Monorepo [2/?] - use hoisted dependencies for Reanimated, app common code and paper example #5999
tjzel
wants to merge
13
commits into
@tjzel/monorepo-husky-and-precommit
from
@tjzel/monorepo-make-reanimated-a-workspace
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
changed the title
Monorepo - use hoisted dependencies for Reanimated and Example apps
Monorepo - use hoisted dependencies for Reanimated, app common code and paper example
May 10, 2024
This was referenced May 13, 2024
tjzel
changed the title
Monorepo - use hoisted dependencies for Reanimated, app common code and paper example
Monorepo [2/?] - use hoisted dependencies for Reanimated, app common code and paper example
May 15, 2024
This was referenced May 15, 2024
This was referenced May 27, 2024
…po-make-reanimated-a-workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
About
This pull request is a part of the effort of migrating to monorepo structure:
Summary
This particular pull request moves
app
directory to a package calledreanimated-app
andExample
directory toreanimated-paper-example
package. It also makes use of hoistednode_modules
for those two packages andreact-native-reanimated
.Test plan
Run
reanimated-paper-example
on both iOS and Android to see that it works.