feat: refactor snapshots when going back on Fabric #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoLewicki
changed the title
tboba
reviewed
May 16, 2024
| @@ -4,7 +4,7 @@ package = JSON.parse(File.read(File.join(__dir__, "package.json"))) | |||
|
|
|||
| new_arch_enabled = ENV['RCT_NEW_ARCH_ENABLED'] == '1' | |||
| platform = new_arch_enabled ? "11.0" : "9.0" | |||
| source_files = new_arch_enabled ? 'ios/**/*.{h,m,mm,cpp}' : ["ios/**/*.{h,m,mm}", "cpp/**/*.{cpp,h}"] | |||
| source_files = new_arch_enabled ? 'ios/**/*.{h,m,mm,cpp}' : ["ios/**/*.{h,m,mm}", "cpp/RNScreensTurboModule.cpp", "cpp/RNScreensTurboModule.h"] | |||
There was a problem hiding this comment.
Why we're not scoping all .cpp and .h files right now?
There was a problem hiding this comment.
Because the new files added to the folder should not be compiled on old arch.
android/CMakeLists.txt
Outdated
Comment on lines
40
to
77
| target_include_directories( | ||
| rnscreens | ||
| PRIVATE | ||
| "${REACT_NATIVE_DIR}/ReactAndroid/src/main/jni/react/turbomodule" | ||
| "${REACT_NATIVE_DIR}/ReactCommon" | ||
| "${REACT_NATIVE_DIR}/ReactCommon/callinvoker" | ||
| "${REACT_NATIVE_DIR}/ReactCommon/react/renderer/graphics/platform/cxx" | ||
| "${REACT_NATIVE_DIR}/ReactCommon/runtimeexecutor" | ||
| "${REACT_NATIVE_DIR}/ReactCommon/yoga" | ||
| ) | ||
|
|
||
| find_package(fbjni REQUIRED CONFIG) | ||
|
|
||
| target_link_libraries( | ||
| rnscreens | ||
| ReactAndroid::jsi | ||
| ReactAndroid::folly_runtime | ||
| ReactAndroid::react_nativemodule_core | ||
| ReactAndroid::react_render_uimanager | ||
| ReactAndroid::react_render_scheduler | ||
| ReactAndroid::react_utils | ||
| ReactAndroid::reactnativejni | ||
| ReactAndroid::fabricjni | ||
| ReactAndroid::react_debug | ||
| ReactAndroid::react_render_core | ||
| ReactAndroid::react_render_mounting | ||
| ReactAndroid::runtimeexecutor | ||
| ReactAndroid::react_render_graphics | ||
| ReactAndroid::rrc_view | ||
| ReactAndroid::yoga | ||
| ReactAndroid::rrc_text | ||
| ReactAndroid::rrc_textinput | ||
| ReactAndroid::react_render_textlayoutmanager | ||
| ReactAndroid::glog | ||
| ReactAndroid::react_render_componentregistry | ||
| fbjni::fbjni | ||
| android | ||
| ) |
There was a problem hiding this comment.
Why will we link all of these modules from now?
There was a problem hiding this comment.
They are all needed to compile the new files. I'll go through them once again to see if we can remove any of those.
There was a problem hiding this comment.
Ok I cleared it a bit. It won't get better than this :D
This was referenced May 17, 2024
|
Hi @WoLewicki! While I was testing all examples from FabricTestExample, I've stumbled onto one app crash while being on the branch from this PR. When I'm trying to run Exception from Logcat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR refactoring snapshots when going back on Fabric on both platforms.