Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unify tests in test apps #2135

Merged
merged 10 commits into from
May 27, 2024
Merged

refactor: unify tests in test apps #2135

merged 10 commits into from
May 27, 2024

Conversation

alduzy
Copy link
Member

@alduzy alduzy commented May 14, 2024

Description

This PR intents to unify tests used by test apps

Changes

  • moved tests to common directory
  • removed duplicates

Test code and steps to reproduce

Checklist

@alduzy alduzy requested a review from maciekstosio May 20, 2024 08:55
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job overall. Left important remark

FabricTestExample/App.js Show resolved Hide resolved
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and there is one more thing. There could be some test cases that were present only in FabricTestExample and not in TestsExample or the other way around. Please make sure, that we do not remove them entirely.

@alduzy alduzy requested a review from kkafar May 20, 2024 12:55
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it looks nice now 🎉

At last we need better name for the tests directory, as this is usually used in context of unit/integration tests and gives wrong clues about its contents. What do you think of test-screens or something similar?

FabricTestExample/App.js Outdated Show resolved Hide resolved
TestsExample/App.js Outdated Show resolved Hide resolved
@alduzy alduzy requested a review from kkafar May 22, 2024 07:08
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good to go 🟢
If you tested & everything is working I think we can proceed.

@alduzy alduzy merged commit b4a4924 into main May 27, 2024
5 checks passed
@alduzy alduzy deleted the @alduzy/unify-tests branch May 27, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants