feat: rewrite indexes to TS #794
Merged
+432
−378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jakub-gonet
reviewed
Feb 5, 2021
| const { enabled = true } = this.props; | ||
|
|
||
| if (!ENABLE_SCREENS || !enabled) { | ||
| // Filter out active prop in this case because it is unused and | ||
| // can cause problems depending on react-native version: | ||
| // https://github.com/react-navigation/react-navigation/issues/4886 | ||
|
|
||
| /* eslint-disable no-unused-vars */ | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars |
There was a problem hiding this comment.
IIRC, we were trying to avoid sending props that did not belong there to the View so we extract enabled.
There was a problem hiding this comment.
You can prefix it with an underscore: _enabled and then eslint should throw this error.
| } | ||
|
|
||
| export class NativeScreen extends React.Component<ScreenProps> { | ||
| render(): JSX.Element { |
There was a problem hiding this comment.
Typing render method on class-based react component seems redundant.
There was a problem hiding this comment.
For some reason eslint warns if I remove it here, but it doesn't in index.native.tsx.
WoLewicki
force-pushed
the
@wolewicki/indexes-to-ts
branch
from
e80b888 to
94d71d8
Compare
This was referenced Mar 15, 2021
This was referenced May 21, 2021
This was referenced Jun 6, 2021
Open
Open
This was referenced Jun 6, 2021
1 task
This was referenced Jul 20, 2021
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR migrating index files from the library library to TS 🎉
Changes
Changed
index.native,indexfiles to TS.Removed
index.d.ts.Added
types.tsx.Changed
package.jsons to properly match new structure of files inlibfolder.Changed
tsconfig.jsonin root to include only files fromsrcand addedtsconfig.jsonfor TestsExample project.Checklist