New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scale 0 is ignored #1435

Open

soh335 wants to merge 1 commit into software-mansion:develop from soh335:scale-0

soh335 commented Aug 12, 2020

Summary

scale={0} is not worked currently. Because scale 0 is fallback to default value (1).

Test Plan

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

<Rect x={0} y={0} width={100} height={100} scale={0} fill="black" />

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS	Implemented
iOS	✅
Android	✅

Checklist

I have tested this on a device and a simulator
I added documentation in README.md
I updated the typed files (typescript)
I added a test for the API in the __tests__ folder


          Fix scale 0 is ignored

d52b403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment