fix(xml): extract tags map to separate entry point for mobile & web #1916
+113
−50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What issues does the pull request solve? Please tag them so that they will get automatically closed once the PR is merged
When utilizing with
react-native-web
: SvgXml and SvgUri are not exported in thesrc/ReactNativeSVG.web.ts
extension. The logic for SvgXml and SvgUri do not have native dependencies, so they are safe to consume on web.Issues:
What is the feature? (if applicable)
Add SvgXml and SvgUri as consumable exports for
react-native-web
How did you implement the solution?
Extract
tags
to shapes map into separatetags.tsx
file, where native shape elements and web shape elements can be provided to their respective envs.What areas of the library does it impact?
src
directoryTest Plan
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
What's required for testing (prerequisites)?
n/a
What are the steps to reproduce (after prerequisites)?
n/a
Compatibility
Checklist
README.md
__tests__
folder