fix: radialGradient r={0}
#2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoLewicki
reviewed
May 13, 2024
| rx = width; | ||
| ry = height; | ||
| CGGradientRelease(gradient); | ||
| NSArray<NSNumber *> *gradientArray = @[_colors.firstObject, _colors.lastObject, _colors[_colors.count-2], _colors.lastObject]; |
There was a problem hiding this comment.
Could you quickly explain what each element of this array corresponds to? And since we have _colors.count-2, is there a case there aren't 3 items in the _colors array?
There was a problem hiding this comment.
Sure! When radialGradient's r=0 it should be painted as a single color using the color of the last stop.
The _colors array corresponds to the Stop elements inside RadialGradient. It consists of offset and stopColor respectively so the gradientArray should look like this
[offset from first, color from last, offset from last, color from last]
In addition, above is a check that _colors.count is not 0 and given that it should always consists of an even number of elements (offset, color), even for stop with no props the default values should be passed.
There was a problem hiding this comment.
Perfect, thanks for the explanation!
github-merge-queue bot
pushed a commit
to valora-inc/wallet
that referenced
this pull request
May 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-svg](https://togithub.com/react-native-community/react-native-svg) | [`^15.2.0` -> `^15.3.0`](https://renovatebot.com/diffs/npm/react-native-svg/15.2.0/15.3.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-community/react-native-svg (react-native-svg)</summary> ### [`v15.3.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v15.3.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v15.2.0...v15.3.0) Minor release fixing some long-standing bugs. Thank you for your contributions! 🎉 #### What's Changed - Add dxguid.lib to release action by [@​Arthurmtro](https://togithub.com/Arthurmtro) in [software-mansion/react-native-svg#2243 - fix: set default strokeWidth to 1 on android by [@​jakex7](https://togithub.com/jakex7) in [software-mansion/react-native-svg#2269 - fix: remove `err` export by [@​jakex7](https://togithub.com/jakex7) in [software-mansion/react-native-svg#2270 - fix: Fix pod install not working with lower version of Cocoapods due to visionOS by [@​jihoon416](https://togithub.com/jihoon416) in [software-mansion/react-native-svg#2240 - fix: Fix static view config validation for RNSVGSvgViewAndroid by [@​fabriziocucci](https://togithub.com/fabriziocucci) in [software-mansion/react-native-svg#2274 - fix: radialGradient `r={0}` by [@​jakex7](https://togithub.com/jakex7) in [software-mansion/react-native-svg#2271 - fix: toDataUrl line breaks by [@​jakex7](https://togithub.com/jakex7) in [software-mansion/react-native-svg#2272 - fix: change android package name by [@​jakex7](https://togithub.com/jakex7) in [software-mansion/react-native-svg#2275 - fix: parsing `<` inside comments by [@​jakex7](https://togithub.com/jakex7) in [software-mansion/react-native-svg#2277 #### New Contributors - [@​Arthurmtro](https://togithub.com/Arthurmtro) made their first contribution in [software-mansion/react-native-svg#2243 - [@​jakex7](https://togithub.com/jakex7) made their first contribution in [software-mansion/react-native-svg#2269 - [@​jihoon416](https://togithub.com/jihoon416) made their first contribution in [software-mansion/react-native-svg#2240 - [@​fabriziocucci](https://togithub.com/fabriziocucci) made their first contribution in [software-mansion/react-native-svg#2274 **Full Changelog**: software-mansion/react-native-svg@v15.2.0...v15.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbIm5wbSIsInJlbm92YXRlIl19--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
<RadialGradient r={0}>.Test Plan
Test is available in
TestsExampleasTest2170Compatibility
Fixes #2170