Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add forge template to scarb new and scarb init under separate flag #1308

Merged
merged 4 commits into from
May 21, 2024
Merged

Add forge template to scarb new and scarb init under separate flag #1308

merged 4 commits into from
May 21, 2024

Conversation

Draggu
Copy link
Contributor

@Draggu Draggu commented May 13, 2024 •
edited

Closes #1208

@Draggu Draggu requested a review from maciektr as a code owner May 13, 2024 15:53
mkaput
mkaput reviewed May 13, 2024
View reviewed changes
scarb/src/bin/scarb/args.rs Outdated Show resolved Hide resolved
maciektr
maciektr reviewed May 13, 2024
View reviewed changes
scarb/src/ops/new.rs Outdated Show resolved Hide resolved
maciektr
maciektr reviewed May 13, 2024
View reviewed changes
scarb/src/ops/new.rs Outdated Show resolved Hide resolved
@Draggu Draggu mentioned this pull request May 14, 2024
Merged
github-merge-queue bot pushed a commit to foundry-rs/starknet-foundry that referenced this pull request May 14, 2024
@Draggu
Update forge template (#2113)
23e92e7 
<!-- Reference any GitHub issues resolved by this PR -->

Related software-mansion/scarb#1308

## Introduced changes

<!-- A brief description of the changes -->

- Add test script to template
- Run `scarb new` only if not run by scarb (see
software-mansion/scarb#1308)
maciektr
maciektr approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about the logic on snforge side (expressed in comment in the forge repo).

This side look good to go!

@maciektr maciektr added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit a5e4c11 May 21, 2024
22 checks passed
@maciektr maciektr deleted the add-forge-template branch May 21, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaput mkaput mkaput approved these changes

@maciektr maciektr maciektr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add forge template to scarb new under separate flag.
3 participants
@Draggu @mkaput @maciektr