[scarb-doc] Add initial crate structures #1309
Conversation
| crate_roots: dependencies, | ||
| crates_config, | ||
| }, | ||
| fn print_module(module: &types::Module) { |
There was a problem hiding this comment.
I know that it's for testing mainly, but this should be implemented via Display nonetheless
There was a problem hiding this comment.
I also feel like sub-structs could also have Displays and so on...
There was a problem hiding this comment.
True, but there's a good chance it'll be removed soon anyway so I didn't bother D; (as you've mentioned it's only for testing)
| const LIB_TARGET_KIND: &str = "lib"; | ||
| const CORELIB_CRATE_NAME: &str = "core"; | ||
|
|
||
| pub fn get_project_config( |
There was a problem hiding this comment.
Mainly yes, some slight refactor changes
| pub definition: String, | ||
|
|
||
| pub text: String, |
There was a problem hiding this comment.
What's the difference between those two?
There was a problem hiding this comment.
It differs for item types but for example, a free function's definition is its signature while text is the whole function
| } | ||
|
|
||
| #[derive(Clone, Debug)] | ||
| pub struct Constant { |
There was a problem hiding this comment.
I feel like all of those defs + impls are repetitive and could be done with a macro with like 3 input vars (pointer type, module type and the ModuleItemId)
There was a problem hiding this comment.
ikr, but they are planned to change and have some separate attributes, so I kept them like this for now
There was a problem hiding this comment.
[nitpick]: Those types are really nice, but i would try to give them each a docstring, for an example code snippet that they represent.
Next PR will add nested attributes to the structures: