Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change default cairo ver #1352

Merged

Conversation

tserg
Copy link
Contributor

@tserg tserg commented May 12, 2024

Partial fix for #1271

Introduced changes

Set the default cairo_version to 1 since Cairo 1 contracts are now the default. Otherwise, initializing a Cairo 1 contract without setting cairo_version=1 throws a validation error.

  • This PR contains breaking changes

Cairo version now defaults to 1.

Copy link
Collaborator

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I left only one tiny comment, but other than that everything looks good to me.

starknet_py/contract.py Show resolved Hide resolved
Copy link
Collaborator

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

Note: Tests on networks are failing due to unset secrets in the forked repository

@ddoktorski
Copy link
Collaborator

@tserg

Feel free to explore other issues, you're welcome to tackle any that you find interesting. Appreciate your work!

@ddoktorski ddoktorski merged commit 5ba387d into software-mansion:development May 27, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants