Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use old approach to create accounts using sncast #130

Open
DelevoXDG opened this issue Jan 11, 2024 · 1 comment · May be fixed by #195
Open

Use old approach to create accounts using sncast #130

DelevoXDG opened this issue Jan 11, 2024 · 1 comment · May be fixed by #195
Assignees
@franciszekjob
Labels
enhancement New feature or request priority: low

Comments

@DelevoXDG
Copy link
Collaborator

DelevoXDG commented Jan 11, 2024 •
edited by franciszekjob

Feature Request

Because newer cast versions with 0.6.0 support don't properly work with tmp directories as of now, currently we have to use a workaround: instead of running sncast account create, we use prepared accounts file with accounts.

This should be changed to use old approach once update to sncast is possible.

Blocked by: foundry-rs/starknet-foundry#1093
@DelevoXDG DelevoXDG added enhancement New feature or request blocked labels Jan 11, 2024
DelevoXDG added a commit that referenced this issue Jan 11, 2024
@DelevoXDG
Bump devnet; Disable tests (#130)
7b0bd46
@THenry14
Copy link
Member

to be determined

@THenry14 THenry14 mentioned this issue Jan 12, 2024
Open
2 tasks
DelevoXDG added a commit that referenced this issue Jan 24, 2024
@DelevoXDG
Support Starknet 0.13 (#129)
8a1040f 
* Add simulation flags for fee estimate

* Add BigUInt.toNumAsHex extension

* Move numerical types from ../Hex/

* Add UInt64AsHex and UInt128AsHex

* Add NumbersTest; Add Felt-specific tests to FeltTests

* Add StarknetDAMode

* Add ResourceBounds

* Move ExecutionResources.swift, TransactionStatus.swift, TransactionType.swift to ./Data

* Add public constructors to StarknetResourceBoundsMapping and StarknetResourceBounds

* Format

* Add new Transaction protocols

- Add `StarknetDeprecatedTransaction` (v1, v2)
- Add `StarknetTransactionV3`
- Add `StarknetDeclareTransaction`, `StarknetDeployAccountTransaction`, `StarknetInvokeTransaction`
- Add `StarknetExecutableTransaction` (helpful for #128)
- Add `StarknetExecutableInvokeTransaction`, `StarknetExecutableDeployAccountTransaction`

* Add StarknetPaymasterData, StarknetAccountDeploymentData typealiases

* Add v3 transactions; Update old ones to conform to new protocols

* Support tx v3 hash calculations

* Misc change

* Refactor StarknetDAMode

- Make `value` type `BigUInt`
- Change to lowercase

* Use StarknetExecutableTransaction instead StarknetTransaction as parameter (#128)

* Fix AddInvokeTransactionParams and Provider.AddInvokeTransaction

* Update JsonRpcError to include data field

* Format

* Fix StarknetAccount.verify

* Bump devnet; Disable tests (#130)

* Update estimateFee: add simulationFlags

* Update est fee test

* Format

* Change v3 field order

* Add ExecutionParamsV3, rename ExecutionParams -> DeprecatedExecutionParams

* Add ExecutionParamsV3, rename ExecutionParams -> DeprecatedExecutionParams (2)

* Remove redundand StarknetAccountestimateVersion

* Add PriceUnit

* Add clamping initializer to NumAsHex and NumAsHexProtocol

* Allow any StarknetExecutableInvokeTransaction in addInvokeTransaction

* Support optional ExecutionParamsV3; Remove

* Add some extra BigUInt extensions

* Add StarknetFeeEstimate.toResourceBounds; Refactor FeeUtils

* Support executeV3

* Fix poseidon (shouldnt use specific cases when list is passed)

* Add accountDeploymentData to StarknetExecutionParamsV3

* Provider: suppport deploy account v3

* Support error data as a String

* Account: support signDeployAccountV3, estimateDeployAccountV3Fee

* Devnet.prefundAccount: support passing unit (prefund with STRK)

* Adjust tests

* Add remaning Account methods

* Rename defaultSimulationFlags -> defaultSimulationFlagsForEstimateFee

* Adjust tests

* Add l1_l2 contract

* Fix estimate message fee test (#89)

* Reenable spec version test

* Add account to ProviderTests

* Re-enable estimate invoke v1; Add estimate tests (inv v3, deploy acc v1, v3)

* Fix testSimulateTransactionsV1

* Remove redundand EstimateFeeTests (now tested on devnet)

* Adjust sim tx v1 tests; Add sim tx v3 tests

* Simplify fee estimation mechanism in StarknetAccount

* Add StarknetFeeEstimate.toMaxFee; Test new fee utils

* Add StarknetFeePayment

* Tx receipt: change `actualFee` type from `Felt` to `StarknetFeePayment`

* Use ints in StarknetExecutionResources

* Update provider tests; Add missing tests

* DevnetClient: cache deployed accounts

* Add testExecuteV3CustomParams

* Test estimateFee w/ and w/o flags

* Refactor sim tx tests

* Remove redundand testSimulateTransactionsResponseDecoding

* Fix tx receipt tests

* Add v1 postfix to account methods

* Clean up tests; Add strk contract address to devnet constants

* Fix tx receipt test

* Rename WrappedSequencerTransaction -> WrappedExecutableTransaction

* Refactor Account for consistency

* Remove redundant parameter from doc description

* Format doc descriptions

* Use .toMaxFee method instead of estimatedFeeToMaxFee

* Move StarknetFeePayment and StarknetPriceUnit to better locations

* Make StarknetDeployAccountTransaction and StarknetDeclareTransaction conform to StarknetTransaction

* Clean up docs comments in Provider

* Update attribution to l1_l2.cairo

* Review changes

* Add missing compiledClassHash to declare v3 tx

* Update TransactionWrapper to handle v3s

* Test v3s in TransactionTests

* Rename computeCommonTransactionV3Fields -> prepareCommonTransactionV3Fields

* Account: Add skipValidate flag to estimate funcs (invoke and deploy)

* Don't skip validate by default in Provider

* Update estimate fee tests

* Add misssing params descriptions

* Fix typos in Provider

* Remove estimatedFeeToMaxFee in favor of StarknetFeeEstimate.toMaxFee

* Separate StarknetExecutionParamsV3 into invoke and deploy account variants

* Account: Don't skipValidate by default in estimateFee methods

* Add nonce=0 constructor for StarknetDeployAccountParamsV3

* Remove unused StarknetOptionalDeployAccountParamsV3

* Add StarknetFeeEstimate.toMaxFee description

* Fix minor inconsistency

* Format

* Add more error w/ data tests

* Remove v3 postfix from v3 params

* Refactor params

- Rename StarknetDeployAccountParams -> StarknetDeployAccountParamsV3
- Rename StarknetInvokeParams -> StarknetInvokeParamsV3
- Split StarknetDeprecatedExecutionParams into StarknetInvokeParamsV1 and StarknetDeployAccountParamsV1

* Remove command printing in DevnetClient
@THenry14 THenry14 removed the blocked label May 13, 2024
@franciszekjob franciszekjob linked a pull request May 21, 2024 that will close this issue
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@franciszekjob franciszekjob

Labels
enhancement New feature or request priority: low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use old approach to create accounts using sncast software-mansion/starknet.swift
3 participants
@THenry14 @DelevoXDG @franciszekjob