New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rollup dependency conflict #366
Conversation
Darn!
(from https://github.com/solana-labs/solana-web3.js/blob/master/.travis.yml#L31) |
@mvines found the issue: rollup/rollup#2961 |
1051857
to
12e8255
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool, thanks!
@mvines turns out "bug" that I found in rollup is actually a feature, who knew! I closed that PR and dug a bit deeper. The real issue is that the |
🎉
|
Hehe awesome, I was hoping it was something dumb like that. The CI failure here is inrelated, I think I know what’s up there |
🎉 This PR is included in version 0.16.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* bump rollup-plugin-node-resolve from 4.2.3 to 5.0.0 * Fix NPM warnings * bump rollup-plugin-commonjs from 9.3.4 to 10.0.0
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Fixes #327