Skip to content
This repository has been archived by the owner on Oct 30, 2023. It is now read-only.

Commit

Permalink
chore: drop unresponsive suppressor for menus (electron#35498)
Browse files Browse the repository at this point in the history
  • Loading branch information
nornagon authored and khalwa committed Feb 22, 2023
1 parent 5ee9d64 commit 7444ac6
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
2 changes: 0 additions & 2 deletions shell/browser/api/electron_api_menu_mac.mm
Expand Up @@ -14,7 +14,6 @@
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/web_contents.h"
#include "shell/browser/native_window.h"
#include "shell/browser/unresponsive_suppressor.h"
#include "shell/common/keyboard_util.h"
#include "shell/common/node_includes.h"

Expand Down Expand Up @@ -156,7 +155,6 @@
base::mac::ScopedSendingEvent sendingEventScoper;

// Don't emit unresponsive event when showing menu.
electron::UnresponsiveSuppressor suppressor;
[menu popUpMenuPositioningItem:item atLocation:position inView:view];
}

Expand Down
4 changes: 0 additions & 4 deletions shell/browser/api/electron_api_menu_views.cc
Expand Up @@ -8,7 +8,6 @@
#include <utility>

#include "shell/browser/native_window_views.h"
#include "shell/browser/unresponsive_suppressor.h"
#include "ui/display/screen.h"

using views::MenuRunner;
Expand Down Expand Up @@ -39,9 +38,6 @@ void MenuViews::PopupAt(BaseWindow* window,

int flags = MenuRunner::CONTEXT_MENU | MenuRunner::HAS_MNEMONICS;

// Don't emit unresponsive event when showing menu.
electron::UnresponsiveSuppressor suppressor;

// Make sure the Menu object would not be garbage-collected until the callback
// has run.
base::OnceClosure callback_with_ref = BindSelfToClosure(std::move(callback));
Expand Down

0 comments on commit 7444ac6

Please sign in to comment.