fix: delegate to PrintViewManagerBase on failed print (electron#34893)

fix: delegate to PrintViewManagerBase on failed print
solarwindscloud · Feb 22, 2023 · b7540e5 · b7540e5
1 parent 5afbefa
commit b7540e5
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/shell/browser/printing/print_view_manager_electron.cc b/shell/browser/printing/print_view_manager_electron.cc
@@ -163,12 +163,23 @@ void PrintViewManagerElectron::ScriptedPrint(
 }
 
 void PrintViewManagerElectron::ShowInvalidPrinterSettingsError() {
+  if (headless_jobs_.size() == 0) {
+    PrintViewManagerBase::ShowInvalidPrinterSettingsError();
+    return;
+  }
+
   ReleaseJob(INVALID_PRINTER_SETTINGS);
 }
 
 void PrintViewManagerElectron::PrintingFailed(
     int32_t cookie,
     printing::mojom::PrintFailureReason reason) {
+  auto entry = std::find(headless_jobs_.begin(), headless_jobs_.end(), cookie);
+  if (entry == headless_jobs_.end()) {
+    PrintViewManagerBase::PrintingFailed(cookie, reason);
+    return;
+  }
+
   ReleaseJob(reason == printing::mojom::PrintFailureReason::kInvalidPageRange
                  ? PAGE_COUNT_EXCEEDED
                  : PRINTING_FAILED);