Skip to content
This repository has been archived by the owner on Oct 30, 2023. It is now read-only.

Commit

Permalink
test: skip flaky test on 32-bit Windows (electron#34021)
Browse files Browse the repository at this point in the history
  • Loading branch information
jkleinsc authored and khalwa committed Feb 22, 2023
1 parent 98d7d3d commit e243fe9
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion spec-main/crash-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { expect } from 'chai';
import * as cp from 'child_process';
import * as fs from 'fs';
import * as path from 'path';
import { ifit } from './spec-helpers';

const fixturePath = path.resolve(__dirname, 'fixtures', 'crash-cases');

Expand Down Expand Up @@ -41,7 +42,8 @@ describe('crash cases', () => {
const cases = fs.readdirSync(fixturePath);

for (const crashCase of cases) {
it(`the "${crashCase}" case should not crash`, () => {
// TODO(jkleinsc) fix this flaky test on Windows 32-bit
ifit(process.platform !== 'win32' || process.arch !== 'ia32' || crashCase !== 'quit-on-crashed-event')(`the "${crashCase}" case should not crash`, () => {
const fixture = path.resolve(fixturePath, crashCase);
const argsFile = path.resolve(fixture, 'electron.args');
const args = [fixture];
Expand Down

0 comments on commit e243fe9

Please sign in to comment.