This repository has been archived by the owner on Oct 30, 2023. It is now read-only.
forked from electron/electron
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Frameless window shows frame while opening (electron#35189)
* fix: Frameless window shows frame while opening * Clarify comments * Inline setter * Edit comment
- Loading branch information
Showing
3 changed files
with
45 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 | ||
From: Raymond Zhao <7199958+rzhao271@users.noreply.github.com> | ||
Date: Tue, 2 Aug 2022 09:30:36 -0700 | ||
Subject: feat: Add set_can_resize mutator | ||
|
||
Adds a set_can_resize mutator to WidgetDelegate that | ||
doesn't emit the OnSizeConstraintsChanged event. | ||
This way, we can call set_can_resize from Electron before | ||
the widget is initialized to set the value earlier, | ||
and in turn, avoid showing a frame at startup | ||
for frameless applications. | ||
|
||
diff --git a/ui/views/widget/widget_delegate.h b/ui/views/widget/widget_delegate.h | ||
index 431d19f2543a9011de76b941982603ff98afa041..32e07e0c9686e6942a40c4d4775a03068cfd33b5 100644 | ||
--- a/ui/views/widget/widget_delegate.h | ||
+++ b/ui/views/widget/widget_delegate.h | ||
@@ -323,6 +323,10 @@ class VIEWS_EXPORT WidgetDelegate { | ||
// be cycled through with keyboard focus. | ||
virtual void GetAccessiblePanes(std::vector<View*>* panes) {} | ||
|
||
+ // A setter for the can_resize parameter that doesn't | ||
+ // emit any events. | ||
+ void set_can_resize(bool can_resize) { params_.can_resize = can_resize; } | ||
+ | ||
// Setters for data parameters of the WidgetDelegate. If you use these | ||
// setters, there is no need to override the corresponding virtual getters. | ||
void SetAccessibleRole(ax::mojom::Role role); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters