Skip to content
This repository has been archived by the owner on Oct 30, 2023. It is now read-only.

Commit

Permalink
chore: upgrade extract-zip for installer (electron#34166)
Browse files Browse the repository at this point in the history
  • Loading branch information
samuelmaddock authored and khalwa committed Feb 22, 2023
1 parent 36a5009 commit fa6c4ce
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 13 deletions.
13 changes: 2 additions & 11 deletions npm/install.js
Expand Up @@ -70,17 +70,8 @@ function isInstalled () {

// unzips and makes path.txt point at the correct executable
function extractFile (zipPath) {
return new Promise((resolve, reject) => {
extract(zipPath, { dir: path.join(__dirname, 'dist') }, err => {
if (err) return reject(err);

fs.writeFile(path.join(__dirname, 'path.txt'), platformPath, err => {
if (err) return reject(err);

resolve();
});
});
});
return extract(zipPath, { dir: path.join(__dirname, 'dist') })
.then(() => fs.promises.writeFile(path.join(__dirname, 'path.txt'), platformPath));
}

function getPlatformPath () {
Expand Down
4 changes: 2 additions & 2 deletions npm/package.json
Expand Up @@ -10,9 +10,9 @@
"dependencies": {
"@electron/get": "^1.14.1",
"@types/node": "^16.11.26",
"extract-zip": "^1.0.3"
"extract-zip": "^2.0.1"
},
"engines": {
"node": ">= 8.6"
"node": ">= 10.17.0"
}
}

0 comments on commit fa6c4ce

Please sign in to comment.