Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ use correct system icons + update icon documentation in general #179

Merged
merged 3 commits into from Jun 21, 2023

Conversation

mariohamann
Copy link
Contributor

@mariohamann mariohamann commented Jun 21, 2023

Issue to be solved

The package storybook-addon-fetch-mock messed up data:-requests, which made it impossible to use it anymore. After digging in the source code and issues of the package (https://github.com/JohnAlbin/storybook-addon-fetch-mock) and its dependency (https://github.com/wheresrhys/fetch-mock) I found a PR, that would fix it: wheresrhys/fetch-mock#607 – but I even it could get it work.

On top: Both packages aren't up-to-date and don't get any updates. I therefore decided to remove them and write the mock function myself. In the end we save a ton of JS in Storybook's frontend, everything feels more maintainable + it just works™️.

Summary of the PR

  1. Fix of the fetch bug
  2. Updated the system icons that it reflects only the icons we currently need. (In preperation for feat(dev): add sd-accordion/-group component #11)
  3. Removed the default library, as this links to bootstrap icons we don't integrate and there we don't need the resolver.
  4. Added story for system icons, to give an overview of the integrated icons + test them proberly
  5. Renamed the current library stories to make clear, that they are examples and not integrated in the components.

@mariohamann
Copy link
Contributor Author

@solid-design-system/development

@mariohamann mariohamann changed the title fix: 🐛 icon system library feat: ✨ use correct system icons + update icon documentation in general Jun 21, 2023
@mariohamann mariohamann merged commit b6c6fd1 into main Jun 21, 2023
2 of 5 checks passed
@mariohamann mariohamann deleted the fix/icon-system-libraray branch June 21, 2023 09:24
mariohamann pushed a commit that referenced this pull request Jun 22, 2023
# [1.1.0](v1.0.0...v1.1.0) (2023-06-21)

### Features

* ✨ use correct system icons + update icon and icon docs ([#179](#179)) ([b6c6fd1](b6c6fd1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants