feat: ✨ use correct system icons + update icon documentation in general #179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue to be solved
The package
storybook-addon-fetch-mock
messed updata:
-requests, which made it impossible to use it anymore. After digging in the source code and issues of the package (https://github.com/JohnAlbin/storybook-addon-fetch-mock) and its dependency (https://github.com/wheresrhys/fetch-mock) I found a PR, that would fix it: wheresrhys/fetch-mock#607 – but I even it could get it work.On top: Both packages aren't up-to-date and don't get any updates. I therefore decided to remove them and write the mock function myself. In the end we save a ton of JS in Storybook's frontend, everything feels more maintainable + it just works™️.
Summary of the PR