Vinxi 0.2.1 -> 0.3.3 (Note: this changes default from vite 4 -> 5) #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dbc0c68 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
birkskyum
changed the title
birkskyum
changed the title
birkskyum
changed the title
birkskyum
force-pushed
the
vinxi-0.3.1
branch
3 times, most recently
from
a863466
to
2a203a9
Compare
birkskyum
force-pushed
the
vinxi-0.3.1
branch
from
2a203a9
to
dbc0c68
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to
I've found usage of
vite/runtime(link below), so I don't trust vinxi 0.3.x, at least thevinxi runto be compatible with vite 4:nksaraf/vinxi@576440c#diff-1f1d67ddefb4f54313fdeafa8e44b64ad7b264539430e97790d1cd4414756581L401
PR Checklist
Please check if your PR fulfills the following requirements:
I went through all the examples to check it didn't break anything. This manual method flagged an issue with vinxi 0.3.0, which is resolved by 0.3.1.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Vinxi 0.2.1 (vite 4 default)
What is the new behavior?
Vinxi 0.3.3 (vite 5 default)
Other information
I set the changeset to a
minor, even though I'd consider it amajor, but I don't know howchangesethandles 0.x.x releases, so let me know if it should be adjusted. Even though I didn't detect anything breaking, it might be reasonable to bump to v0.6.0.