Move RequestEventLocals type definition into a namespace to make the retyping easier for users #1469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When defining a
RequestEventLocals
type for a custom app typescript does not pickup the types until it the file also contains a top level import/export.What is the new behavior?
Now instead of declare module we declare a namespace that does not confuse typescript and makes sure the
global.d.ts
is interpreted as an augmentation module (not ambient as before)Other information
Related to #1466 unfortunately this would require current users to re-config their typings. (from module to namespace)