fix: use moduleResolution: "bundler"
in examples
#1476
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
-> The examples still build successfully
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The examples have
moduleResolution
set tonode
, which is outdated and only compatible with cjs. This can lead to resolution issues with esm only libraries.Reference: https://www.typescriptlang.org/tsconfig/#moduleResolution
What is the new behavior?
By using
moduleResolution: "bundler"
, we're making sure to also support esm modules. the vite starter uses this too (pnpm create vite
)Other information