Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use moduleResolution: "bundler" in examples #1476

Merged
merged 3 commits into from
May 20, 2024
Merged

Conversation

GiyoMoon
Copy link
Contributor

@GiyoMoon GiyoMoon commented May 14, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

-> The examples still build successfully

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • infrastructure changes
  • Other... Please describe:

What is the current behavior?

The examples have moduleResolution set to node, which is outdated and only compatible with cjs. This can lead to resolution issues with esm only libraries.

Reference: https://www.typescriptlang.org/tsconfig/#moduleResolution

What is the new behavior?

By using moduleResolution: "bundler", we're making sure to also support esm modules. the vite starter uses this too (pnpm create vite)

Other information

Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: 0d6ece0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ryansolid ryansolid merged commit eb296f2 into solidjs:main May 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants