Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust some JSDocs #2081

Merged
merged 2 commits into from
Feb 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/real-deers-end.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"solid-js": patch
---

Adjust some JSDocs
5 changes: 3 additions & 2 deletions packages/solid/src/reactive/array.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,9 @@ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
*/

/**
* reactively transforms an array with a callback function - underlying helper for the `<For>` control flow
* Reactively transforms an array with a callback function - underlying helper for the `<For>` control flow
*
* similar to `Array.prototype.map`, but gets the index as accessor, transforms only values that changed and returns an accessor and reactively tracks changes to the list.
*
Expand Down Expand Up @@ -175,7 +176,7 @@ export function mapArray<T, U>(
}

/**
* reactively maps arrays by index instead of value - underlying helper for the `<Index>` control flow
* Reactively maps arrays by index instead of value - underlying helper for the `<Index>` control flow
*
* similar to `Array.prototype.map`, but gets the value as an accessor, transforms only changed items of the original arrays anew and returns an accessor.
*
Expand Down
2 changes: 1 addition & 1 deletion packages/solid/src/reactive/observable.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export type ObservableObserver<T> =
complete?: (v: boolean) => void;
};
/**
* creates a simple observable from a signal's accessor to be used with the `from` operator of observable libraries like e.g. rxjs
* Creates a simple observable from a signal's accessor to be used with the `from` operator of observable libraries like e.g. rxjs
* ```typescript
* import { from } from "rxjs";
* const [s, set] = createSignal(0);
Expand Down
10 changes: 5 additions & 5 deletions packages/solid/src/reactive/signal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -902,7 +902,7 @@ export interface OnOptions {
}

/**
* on - make dependencies of a computation explicit
* Makes dependencies of a computation explicit
* ```typescript
* export function on<S, U>(
* deps: Accessor<S> | AccessorArray<S>,
Expand Down Expand Up @@ -962,7 +962,7 @@ export function on<S, Next extends Prev, Prev = Next>(
}

/**
* onMount - run an effect only after initial render on mount
* Runs an effect only after initial render on mount
* @param fn an effect that should run only once on mount
*
* @description https://www.solidjs.com/docs/latest/api#onmount
Expand All @@ -972,7 +972,7 @@ export function onMount(fn: () => void) {
}

/**
* onCleanup - run an effect once before the reactive scope is disposed
* Runs an effect once before the reactive scope is disposed
* @param fn an effect that should run only once on cleanup
*
* @returns the same {@link fn} function that was passed in
Expand All @@ -989,7 +989,7 @@ export function onCleanup<T extends () => any>(fn: T): T {
}

/**
* catchError - run an effect whenever an error is thrown within the context of the child scopes
* Runs an effect whenever an error is thrown within the context of the child scopes
* @param fn boundary for the error
* @param handler an error handler that receives the error
*
Expand Down Expand Up @@ -1176,7 +1176,7 @@ export function createContext<T>(
}

/**
* use a context to receive a scoped state from a parent's Context.Provider
* Uses a context to receive a scoped state from a parent's Context.Provider
*
* @param context Context object made by `createContext`
* @returns the current or `defaultValue`, if present
Expand Down
4 changes: 2 additions & 2 deletions packages/solid/src/render/Suspense.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const suspenseListEquals = (a: SuspenseListRegisteredState, b: SuspenseListRegis
const SuspenseListContext = createContext<SuspenseListContextType>();

/**
* **[experimental]** controls the order in which suspended content is rendered
* **[experimental]** Controls the order in which suspended content is rendered
*
* @description https://www.solidjs.com/docs/latest/api#suspenselist-experimental
*/
Expand Down Expand Up @@ -110,7 +110,7 @@ export function SuspenseList(props: {
}

/**
* tracks all resources inside a component and renders a fallback until they are all resolved
* Tracks all resources inside a component and renders a fallback until they are all resolved
* ```typescript
* const AsyncComponent = lazy(() => import('./component'));
*
Expand Down
8 changes: 4 additions & 4 deletions packages/solid/src/render/flow.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const narrowedError = (name: string) =>
: `Stale read from <${name}>.`;

/**
* creates a list elements from a list
* Creates a list elements from a list
*
* it receives a map function as its child that receives a list element and an accessor with the index and returns a JSX-Element; if the list is empty, an optional fallback is returned:
* ```typescript
Expand Down Expand Up @@ -144,7 +144,7 @@ export function Show<T>(props: {
type EvalConditions = readonly [number, unknown?, MatchProps<unknown>?];

/**
* switches between content based on mutually exclusive conditions
* Switches between content based on mutually exclusive conditions
* ```typescript
* <Switch fallback={<FourOhFour />}>
* <Match when={state.route === 'home'}>
Expand Down Expand Up @@ -208,7 +208,7 @@ export type MatchProps<T> = {
children: JSX.Element | ((item: NonNullable<T> | Accessor<NonNullable<T>>) => JSX.Element);
};
/**
* selects a content based on condition when inside a `<Switch>` control flow
* Selects a content based on condition when inside a `<Switch>` control flow
* ```typescript
* <Match when={condition()}>
* <Content/>
Expand Down Expand Up @@ -238,7 +238,7 @@ export function resetErrorBoundaries() {
Errors && [...Errors].forEach(fn => fn());
}
/**
* catches uncaught errors inside components and renders a fallback content
* Catches uncaught errors inside components and renders a fallback content
*
* Also supports a callback form that passes the error and a reset function:
* ```typescript
Expand Down
2 changes: 1 addition & 1 deletion packages/solid/store/src/store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ export interface SetStoreFunction<T> {
}

/**
* creates a reactive store that can be read through a proxy object and written with a setter function
* Creates a reactive store that can be read through a proxy object and written with a setter function
*
* @description https://www.solidjs.com/docs/latest/api#createstore
*/
Expand Down
5 changes: 3 additions & 2 deletions packages/solid/web/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export const hydrate: typeof hydrateCore = (...args) => {
};

/**
* renders components somewhere else in the DOM
* Renders components somewhere else in the DOM
*
* Useful for inserting modals and tooltips outside of an cropping layout. If no mount point is given, the portal is inserted in document.body; it is wrapped in a `<div>` unless the target is document.head or `isSVG` is true. setting `useShadow` to true places the element in a shadow root to isolate styles.
*
Expand Down Expand Up @@ -113,8 +113,9 @@ export type DynamicProps<T extends ValidComponent, P = ComponentProps<T>> = {
} & {
component: T | undefined;
};

/**
* renders an arbitrary custom or native component and passes the other props
* Renders an arbitrary custom or native component and passes the other props
* ```typescript
* <Dynamic component={multiline() ? 'textarea' : 'input'} value={value()} />
* ```
Expand Down